[PR #5366] [MERGED] Reduce Skia conversions #10321

Closed
opened 2025-12-22 07:59:12 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/5366
Author: @ferferga
Created: 3/4/2021
Status: Merged
Merged: 3/31/2025
Merged by: @crobibero

Base: masterHead: skia-improvement


📝 Commits (1)

  • 4968713 Reduce SKImage to SKBitmap conversion, high quality canvas

📊 Changes

2 files changed (+19 additions, -19 deletions)

View changed files

📝 src/Jellyfin.Drawing.Skia/SkiaEncoder.cs (+7 -13)
📝 src/Jellyfin.Drawing.Skia/StripCollageBuilder.cs (+12 -6)

📄 Description

Includes the warnings fixes from #5360

  • The resizing process involved multiple SKImage to SKBitmap conversions. Reduced those conversions and using the native methods that Skia provides for drawing each Canvas
  • Use High quality filter on all the canvas.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/5366 **Author:** [@ferferga](https://github.com/ferferga) **Created:** 3/4/2021 **Status:** ✅ Merged **Merged:** 3/31/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `skia-improvement` --- ### 📝 Commits (1) - [`4968713`](https://github.com/jellyfin/jellyfin/commit/49687130b684914a6ca7d546760d79f802420d33) Reduce SKImage to SKBitmap conversion, high quality canvas ### 📊 Changes **2 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+7 -13) 📝 `src/Jellyfin.Drawing.Skia/StripCollageBuilder.cs` (+12 -6) </details> ### 📄 Description Includes the warnings fixes from #5360 * The resizing process involved multiple SKImage to SKBitmap conversions. Reduced those conversions and using the native methods that Skia provides for drawing each Canvas * Use High quality filter on all the canvas. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-22 07:59:12 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10321
No description provided.