[PR #4693] [CLOSED] Safer startup. #10051

New issue

Closed

opened 2025-12-22 07:49:25 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-22 07:49:25 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/4693
Author: @BaronGreenback
Created: 12/6/2020
Status: ❌ Closed

Base: master ← Head: startupFix

📝 Commits (3)

02ca75f Update ApplicationHost.cs
3652e95 Made it compile.
e959a89 Update Emby.Server.Implementations/ApplicationHost.cs

📊 Changes

1 file changed (+21 additions, -2 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+21 -2)

📄 Description

It looks like it would be possible for a plugin to crash the system by generating an exception in their IServerEntryPoint implementation.

All methods are executed by a Task.WhenAll. According to the docs, this only reports the last error generated, and if i'm reading the code right, would crash.

This PR introduces another exception catching layer between the two. This should enable failed plugins to log exceptions without a crashing occurring.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/4693 **Author:** [@BaronGreenback](https://github.com/BaronGreenback) **Created:** 12/6/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `startupFix` --- ### 📝 Commits (3) - [`02ca75f`](https://github.com/jellyfin/jellyfin/commit/02ca75f19c928f8dde162b055568748eac6f84d7) Update ApplicationHost.cs - [`3652e95`](https://github.com/jellyfin/jellyfin/commit/3652e9553016cfefe09c66b9f9eebce7aa28fc89) Made it compile. - [`e959a89`](https://github.com/jellyfin/jellyfin/commit/e959a89390204b5b28a75072e4c81c1fa5513984) Update Emby.Server.Implementations/ApplicationHost.cs ### 📊 Changes **1 file changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+21 -2) </details> ### 📄 Description It looks like it would be possible for a plugin to crash the system by generating an exception in their IServerEntryPoint implementation. All methods are executed by a Task.WhenAll. According to the docs, this only reports the last error generated, and if i'm reading the code right, would crash. This PR introduces another exception catching layer between the two. This should enable failed plugins to log exceptions without a crashing occurring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

backuprepo

2025-12-22 07:49:26 +01:00

closed this issue
added the
pull-request
label

backuprepo referenced this issue

2025-12-22 09:07:57 +01:00

[PR #10051] [MERGED] Refactor URI overrides #12140

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#10051

No description provided.

Rows
Columns