[PR #27] [CLOSED] rkmppdec: allow user to force drm:prime format when decoding to prevent #242

Closed
opened 2025-12-23 10:36:36 +01:00 by backuprepo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nyanmisaka/ffmpeg-rockchip/pull/27
Author: @hbiyik
Created: 2/12/2024
Status: Closed

Base: masterHead: force_drm


📝 Commits (1)

  • bb9758a rkmppdec: allow user to force drm:prime format when decoding to prevent

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 libavcodec/rkmppdec.c (+5 -0)
📝 libavcodec/rkmppdec.h (+2 -0)

📄 Description

as in case some players can not pickup the right format.

in the cases where it is obvious like moonlight i create mainline PRs to players but there are such corner cases as mpv's i really dont know where the exact issue is.

ie: mpv picks up
correct drm_prime format for https://www.youtube.com/watch?v=aqz-KE-bpKQ, vp9 with mp4
but not for https://youtu.be/BJ3Yv572V1A, h264 with hls. choses nv12.
could be even a demuxer/container issue, who knows.

can we provide such a workaround for those cases?

as a side note, i would just suggest completely removing any form of format which is not drm_prime. It saves from future pain.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nyanmisaka/ffmpeg-rockchip/pull/27 **Author:** [@hbiyik](https://github.com/hbiyik) **Created:** 2/12/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `force_drm` --- ### 📝 Commits (1) - [`bb9758a`](https://github.com/nyanmisaka/ffmpeg-rockchip/commit/bb9758ae7ae45cfaff059866e6e1e6d72815636c) rkmppdec: allow user to force drm:prime format when decoding to prevent ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `libavcodec/rkmppdec.c` (+5 -0) 📝 `libavcodec/rkmppdec.h` (+2 -0) </details> ### 📄 Description as in [case](https://forum.radxa.com/t/archlinux-on-rock5b/13851/411?u=boogiepop) some players can not pickup the right format. in the cases where it is obvious like [moonlight](https://github.com/moonlight-stream/moonlight-qt/pull/1167) i create mainline PRs to players but there are such corner cases as mpv's i really dont know where the exact issue is. ie: mpv picks up correct drm_prime format for https://www.youtube.com/watch?v=aqz-KE-bpKQ, vp9 with mp4 but not for https://youtu.be/BJ3Yv572V1A, h264 with hls. choses nv12. could be even a demuxer/container issue, who knows. can we provide such a workaround for those cases? as a side note, i would just suggest completely removing any form of format which is not drm_prime. It saves from future pain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
backuprepo 2025-12-23 10:36:36 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: starred/ffmpeg-rockchip#242
No description provided.