[PR #4] [CLOSED] rkmppdec: Allow to change AFBC mode from env #232

New issue

Closed

opened 2025-12-23 10:36:31 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-23 10:36:31 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nyanmisaka/ffmpeg-rockchip/pull/4
Author: @hbiyik
Created: 1/4/2024
Status: ❌ Closed

Base: master ← Head: ffmpeg-rockchip-decoder-afbc

📝 Commits (1)

b987b0c rkmppdec: Parse decoder options via FFMPEG_RKMPP_DEC_OPT

📊 Changes

1 file changed (+14 additions, -3 deletions)

View changed files

📝 libavcodec/rkmppdec.c (+14 -3)

📄 Description

This helps video players which do not support AVOptions (ie:Kodi) to use AFBC mode.

With this change and this PR in Kodi, i initially got AFBC output. However i think there are some problems:

Output of AV1:

Output of H264 & Hevc

Output of VP9:

With VP9 you can see it is almost correct except some stride issue, i think it should be divided by 4.
However with H264, HEVC and AV1 it seems that there are some other issues, i suspect some of those modifiers might differ from decoder to decoder.

As always please do not merge yet :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nyanmisaka/ffmpeg-rockchip/pull/4 **Author:** [@hbiyik](https://github.com/hbiyik) **Created:** 1/4/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ffmpeg-rockchip-decoder-afbc` --- ### 📝 Commits (1) - [`b987b0c`](https://github.com/nyanmisaka/ffmpeg-rockchip/commit/b987b0c0407bbf134dd4edf3e095d3d7880f0998) rkmppdec: Parse decoder options via FFMPEG_RKMPP_DEC_OPT ### 📊 Changes **1 file changed** (+14 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `libavcodec/rkmppdec.c` (+14 -3) </details> ### 📄 Description This helps video players which do not support AVOptions (ie:Kodi) to use AFBC mode. With this change and this [PR](https://github.com/xbmc/xbmc/pull/24431) in Kodi, i initially got AFBC output. However i think there are some problems: Output of AV1: ![20240104_142344](https://github.com/nyanmisaka/ffmpeg-rockchip/assets/24766436/51c45958-a00c-41d0-9c0f-dcb70e1b0b6e) Output of H264 & Hevc ![20240104_142328](https://github.com/nyanmisaka/ffmpeg-rockchip/assets/24766436/2b128850-e0b5-4750-a9ee-bf68e90ea998) Output of VP9: ![20240104_142127](https://github.com/nyanmisaka/ffmpeg-rockchip/assets/24766436/aeec4ff7-733f-4e9d-bff4-c2e9a807e3a8) With VP9 you can see it is almost correct except some stride issue, i think it should be divided by 4. However with H264, HEVC and AV1 it seems that there are some other issues, i suspect some of those modifiers might differ from decoder to decoder. As always please do not merge yet :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>