[PR #2] [CLOSED] Introduce AVRKMPPDRMFrameDescriptor #231

New issue

Closed

opened 2025-12-23 10:36:31 +01:00 by backuprepo · 0 comments

backuprepo commented

2025-12-23 10:36:31 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nyanmisaka/ffmpeg-rockchip/pull/2
Author: @hbiyik
Created: 1/1/2024
Status: ❌ Closed

Base: master ← Head: ffmpeg-rockchip-keepapi

📝 Commits (1)

94e9a39 lavu: Introduce AVRKMPPDRMFrameDescriptor

📊 Changes

4 files changed (+56 additions, -64 deletions)

View changed files

📝 libavcodec/rkmppdec.c (+3 -4)
📝 libavutil/hwcontext_drm.h (+0 -10)
📝 libavutil/hwcontext_rkmpp.c (+36 -49)
📝 libavutil/hwcontext_rkmpp.h (+17 -1)

📄 Description

This is exactly like AVDRMFrameDescriptor but attionally it holds MppBuffer instance used on each index. With that, AVDRMObjectDescriptor can be kept as is, and no need to modify the existing API.

MajorChanges:
Introduce AVRKMPPDRMFrameDescriptor which is inheriting AVDRMFrameDescriptor. Note: if ptr is accepted to be a member off AVDRMObjectDescriptor, then this change would not be necessary. Open for discussion.

Adapt hwcontext_rkmpp.c from AVDRMFrameDescriptor->AVRKMPPDRMFrameDescriptor. (Decoder / encoder and rga scalers are still using AVDRMFrameDescriptor and i think this is fine for future compatibility.)

Remove rkmpp_buffer_free, and use only rkmpp_free_drm_frame_descriptor for both desc and mpp_buf clean up. With this, there is no need to reference tge mppbuffer to drmdescriptor.

Not througly tested yet.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nyanmisaka/ffmpeg-rockchip/pull/2 **Author:** [@hbiyik](https://github.com/hbiyik) **Created:** 1/1/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ffmpeg-rockchip-keepapi` --- ### 📝 Commits (1) - [`94e9a39`](https://github.com/nyanmisaka/ffmpeg-rockchip/commit/94e9a396d3abb8db6b65d3c99b85ba44b39fdcbf) lavu: Introduce AVRKMPPDRMFrameDescriptor ### 📊 Changes **4 files changed** (+56 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `libavcodec/rkmppdec.c` (+3 -4) 📝 `libavutil/hwcontext_drm.h` (+0 -10) 📝 `libavutil/hwcontext_rkmpp.c` (+36 -49) 📝 `libavutil/hwcontext_rkmpp.h` (+17 -1) </details> ### 📄 Description This is exactly like AVDRMFrameDescriptor but attionally it holds MppBuffer instance used on each index. With that, AVDRMObjectDescriptor can be kept as is, and no need to modify the existing API. MajorChanges: Introduce AVRKMPPDRMFrameDescriptor which is inheriting AVDRMFrameDescriptor. Note: if ptr is accepted to be a member off AVDRMObjectDescriptor, then this change would not be necessary. Open for discussion. Adapt hwcontext_rkmpp.c from AVDRMFrameDescriptor->AVRKMPPDRMFrameDescriptor. (Decoder / encoder and rga scalers are still using AVDRMFrameDescriptor and i think this is fine for future compatibility.) Remove rkmpp_buffer_free, and use only rkmpp_free_drm_frame_descriptor for both desc and mpp_buf clean up. With this, there is no need to reference tge mppbuffer to drmdescriptor. Not througly tested yet. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>