starred/ffmpeg-rockchip
1
0
Fork 0
mirror of https://github.com/nyanmisaka/ffmpeg-rockchip.git synced 2026-01-23 23:21:06 +01:00
Code Issues 5 Projects Packages Wiki Activity Actions

avcodec/svt-av1: Set force_key_frames only when gop_size == 1

Browse source 
SVT-AV1 does not support requesting keyframes at arbitrary points
by setting pic_type to EB_AV1_KEY_PICTURE. So set force_key_frames
to 1 only when gop_size == 1.

Please see the comments in
https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 for a bit more
details.

Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
This commit is contained in:
Vignesh Venkatasubramanian via ffmpeg-devel 2023-10-03 15:53:06 -07:00 • committed by Ronald S. Bultje
parent f0f6acde1a
commit e8465aa5dd
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
libavcodec/libsvtav1.c
View file

@ -253,8 +253,13 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
// In order for SVT-AV1 to force keyframes by setting pic_type to
// EB_AV1_KEY_PICTURE on any frame, force_key_frames has to be set. Note
// that this does not force all frames to be keyframes (it only forces a
// keyframe with pic_type is set to EB_AV1_KEY_PICTURE).
param->force_key_frames = 1;
// keyframe with pic_type is set to EB_AV1_KEY_PICTURE). As of now, SVT-AV1
// does not support arbitrary keyframe requests by setting pic_type to
// EB_AV1_KEY_PICTURE, so it is done only when gop_size == 1.
// FIXME: When SVT-AV1 supports arbitrary keyframe requests, this code needs
// to be updated to set force_key_frames accordingly.
if (avctx->gop_size == 1)
param->force_key_frames = 1;
if (avctx->framerate.num > 0 && avctx->framerate.den > 0) {
param->frame_rate_numerator = avctx->framerate.num;