starred/archived-mpp
1
0
Fork 0
mirror of https://github.com/nyanmisaka/mpp.git synced 2025-12-26 11:17:44 +01:00
Code Issues Projects Packages Wiki Activity Actions

Revert "fix[h264d_parser]: Fix pps parsing issue"

Browse source 
This reverts commit 1f8aafea1c.

Platform: General
Spec: h264

Solution:

The base line profile, Main profile, and Extended profile do not
support transform_8x8_mode_flag, pic_scaling_matrix_present_flag,
and second_chroma_qp_index_offset.

However, nonstandard sequences may incorrectly include certain
fields and some extensions or custom implementations may violate
the standard

Therefore, the processing here is strictly carried out according
to the sequence processing logic provided by the spec

Consider #516724, it has been confirmed that it is caused by
incomplete sequence reception. The revert patch here does not
affect the correctness of mpp processing

Reported-by: redmine #543598

Source:
base_line.h264
atomos_mainprofile.h264

Change-Id: I130216a3d7c1651076c3e8037b5079ea5f54e62c
Signed-off-by: Hongjin Li <vic.hong@rock-chips.com>
This commit is contained in:
Hongjin Li 2025-03-31 10:32:51 +08:00
parent 5d7a5cb7c5
commit c48894c134
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
mpp/codec/dec/h264/h264d_pps.c
View file

@ -96,10 +96,7 @@ static MPP_RET parser_pps(BitReadCtx_t *p_bitctx, H264_SPS_t *cur_sps, H264_PPS_
READ_ONEBIT(p_bitctx, &cur_pps->redundant_pic_cnt_present_flag);
VAL_CHECK(ret , cur_pps->redundant_pic_cnt_present_flag == 0);
if (mpp_has_more_rbsp_data(p_bitctx) &&
(cur_sps->profile_idc != 66) && /* base line profile */
(cur_sps->profile_idc != 77) && /* Main profile */
(cur_sps->profile_idc != 88)) { /* Extended profile */
if (mpp_has_more_rbsp_data(p_bitctx)) {
READ_ONEBIT(p_bitctx, &cur_pps->transform_8x8_mode_flag);
READ_ONEBIT(p_bitctx, &cur_pps->pic_scaling_matrix_present_flag);
if (cur_pps->pic_scaling_matrix_present_flag) {