DuDu371/linux-rockchip
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
linux-rockchip/sound/firewire
History
Exact
Andrey Shumilin d2826873db ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size() 
[ Upstream commit 72cafe63b35d06b5cfbaf807e90ae657907858da ]

The step variable is initialized to zero. It is changed in the loop,
but if it's not changed it will remain zero. Add a variable check
before the division.

The observed behavior was introduced by commit 826b5de90c
("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size"),
and it is difficult to show that any of the interval parameters will
satisfy the snd_interval_test() condition with data from the
amdtp_rate_table[] table.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 826b5de90c ("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size")
Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20241018060018.1189537-1-shum.sdl@nppct.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-01 01:56:05 +01:00
..
bebob
dice
digi00x
fireface
fireworks
motu
oxfw
tascam
amdtp-am824.c
amdtp-am824.h
amdtp-stream-trace.h
amdtp-stream.c ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size() 2024-11-01 01:56:05 +01:00
amdtp-stream.h Revert "ALSA: firewire-lib: obsolete workqueue for period update" 2024-08-11 12:36:00 +02:00
cmp.c
cmp.h
fcp.c
fcp.h
isight.c
iso-resources.c
iso-resources.h
Kconfig
lib.c
lib.h
Makefile
packets-buffer.c
packets-buffer.h